On Tue, 2024-01-23 at 08:45 -0800, Jakub Kicinski wrote:
On Mon, 22 Jan 2024 15:34:34 +0000 (UTC) Kalle Valo wrote:
Lukas Bulwahn (1): wifi: cfg80211/mac80211: remove dependency on non-existing option
BTW we run all kernel's kunit tests on netdev periodically by doing:
./tools/testing/kunit/kunit.py run --all
and AFAICT the WiFi tests don't pop up there :(
https://netdev.bots.linux.dev/contest.html?branch=net-next-2024-01-23--15-00...
Is that on purpose?
No, but honestly, I didn't even really know about it, which is mostly for lack of bothering to look - because we run them in a different way now both in upstream hostap and internally (internally we also have another file with metadata to tie them to other bits of the whole project that isn't interesting upstream).
Looks like that needs adjustments to the config file there, mostly? I can see about adding that, probably not that hard, at least for mac80211/cfg80211.
++kunit folks:
We're also adding unit tests to iwlwifi (slowly), any idea if we should enable that here also? It _is_ now possible to build PCI stuff on kunit, but it requires some additional config options (virt-pci etc.), not sure that's desirable here? It doesn't need it at runtime for the tests, of course.
johannes