-----Original Message----- From: Paolo Abeni pabeni@redhat.com Sent: Tuesday, May 20, 2025 3:38 PM To: Eric Dumazet edumazet@google.com; Chia-Yu Chang (Nokia) chia-yu.chang@nokia-bell-labs.com Cc: linux-doc@vger.kernel.org; corbet@lwn.net; horms@kernel.org; dsahern@kernel.org; kuniyu@amazon.com; bpf@vger.kernel.org; netdev@vger.kernel.org; dave.taht@gmail.com; jhs@mojatatu.com; kuba@kernel.org; stephen@networkplumber.org; xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net; andrew+netdev@lunn.ch; donald.hunter@gmail.com; ast@fiberby.net; liuhangbin@gmail.com; shuah@kernel.org; linux-kselftest@vger.kernel.org; ij@kernel.org; ncardwell@google.com; Koen De Schepper (Nokia) koen.de_schepper@nokia-bell-labs.com; g.white g.white@cablelabs.com; ingemar.s.johansson@ericsson.com; mirja.kuehlewind@ericsson.com; cheshire@apple.com; rs.ietf@gmx.at; Jason_Livingood@comcast.com; vidhi_goel vidhi_goel@apple.com Subject: Re: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option
CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
On 5/20/25 12:32 PM, Eric Dumazet wrote:
On Tue, May 20, 2025 at 2:31 AM Paolo Abeni pabeni@redhat.com wrote:
On 5/14/25 3:56 PM, chia-yu.chang@nokia-bell-labs.com wrote:
This patch uses the existing 1-byte holes in the tcp_sock_write_txrx group for new u8 members, but adds a 4-byte hole in tcp_sock_write_rx group after the new u32 delivered_ecn_bytes[3] member. Therefore, the group size of tcp_sock_write_rx is increased from 96 to 112.
Note that I'm still concerned by the relevant increase of the cacheline groups size. My fear is that this change could defeat some/most of the benefist from the cacheline reorg for all tcp users.
Some additional feedback from Eric and/or Neal more than welcome!
I have been trapped lately with production issues, sorry for the delay.
I am still working on an idpf bug, hopefully done today.
Then, I am OOO tomorrow, and can have a look at the whole series on Thursday.
Thanks Eric!
@Chia-Yu: please consider the above timeline before posting a new revision. i.e. it would be likely wise to wait for the additional review.
/P
Hi Eric and Paolo,
As you know that the merge window for v6.16 is begun and net-next is closed for new features till 9th of June.
May I ask did you manage yo review the patches we sent two weeks ago?
Thanks.
Best Regards, Chia-Yu