Re: [PATCH 11/15] selftests/seccomp: Remove SYSCALL_NUM_RET_SHARE_REG in favor of SYSCALL_RET_SET

On Sat, Sep 12, 2020 at 04:08:16AM -0700, Kees Cook wrote:

Instead of special-casing the specific case of shared registers, create a default SYSCALL_RET_SET() macro (mirroring SYSCALL_NUM_SET()), that writes to the SYSCALL_RET register. For architectures that can't set the return value (for whatever reason), they can define SYSCALL_RET_SET() without an associated SYSCALL_RET() macro. This also paves the way for architectures that need to do special things to set the return value (e.g. powerpc).

Signed-off-by: Kees Cook keescook@chromium.org

Looks good! Acked-by: Christian Brauner christian.brauner@ubuntu.com