Re: [PATCH v2 4/5] lib/Kconfig.debug: properly split hash test kernel entries

On Mon, Sep 27, 2021 at 6:33 AM Isabella Basso isabellabdoamaral@usp.br wrote:

Split TEST_HASH so that each entry only has one file.

Note that there's no stringhash test file, but actually <linux/stringhash.h> tests are performed in lib/test_hash.c.

Tested-by: David Gow davidgow@google.com Signed-off-by: Isabella Basso isabellabdoamaral@usp.br

---

Looks good to me.

Reviewed-by: David Gow davidgow@google.com

Cheers, -- David

lib/Kconfig.debug | 14 +++++++++++--- lib/Makefile | 3 ++- 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 2a9b6dcdac4f..eb6c4daf5fcb 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -2207,9 +2207,17 @@ config TEST_RHASHTABLE config TEST_HASH tristate "Perform selftest on hash functions" help

•     Enable this option to test the kernel's integer (<linux/hash.h>),
  

•     string (<linux/stringhash.h>), and siphash (<linux/siphash.h>)
  

•     hash functions on boot (or module load).
  

•     Enable this option to test the kernel's integer (<linux/hash.h>), and
  

•     string (<linux/stringhash.h>) hash functions on boot (or module load).
  

•     This is intended to help people writing architecture-specific
  

•     optimized versions.  If unsure, say N.
  

+config TEST_SIPHASH

•   tristate "Perform selftest on siphash functions"
  

•   help
  

•     Enable this option to test the kernel's siphash (<linux/siphash.h>) hash
  

•     functions on boot (or module load).
  
      This is intended to help people writing architecture-specific
      optimized versions.  If unsure, say N.
  

diff --git a/lib/Makefile b/lib/Makefile index 5efd1b435a37..c2e81d0eb31c 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -61,7 +61,8 @@ obj-$(CONFIG_TEST_FIRMWARE) += test_firmware.o obj-$(CONFIG_TEST_BITOPS) += test_bitops.o CFLAGS_test_bitops.o += -Werror obj-$(CONFIG_TEST_SYSCTL) += test_sysctl.o -obj-$(CONFIG_TEST_HASH) += test_hash.o test_siphash.o +obj-$(CONFIG_TEST_SIPHASH) += test_siphash.o +obj-$(CONFIG_TEST_HASH) += test_hash.o obj-$(CONFIG_TEST_IDA) += test_ida.o obj-$(CONFIG_KASAN_KUNIT_TEST) += test_kasan.o CFLAGS_test_kasan.o += -fno-builtin -- 2.33.0