Re: [PATCH 1/4] lib: Make prime number generator independently selectable

On Thu, 28 May 2020 22:56:59 -0700 Kees Cook keescook@chromium.org wrote:

On Thu, May 28, 2020 at 11:52:06PM +0900, Masami Hiramatsu wrote:

...

Make prime number generator independently selectable from kconfig. This allows us to enable CONFIG_PRIME_NUMBERS=m and run the tools/testing/selftests/lib/prime_numbers.sh without other DRM selftest modules.

Nice catch! I see that tools/testing/selftests/lib/config already has CONFIG_PRIME_NUMBERS=m (based on this commit log I was expecting to see it added in the diff, but I see it's not needed).

Yes, that is the reason why I have found this issue, the "make kselftest-merge" cannot enable CONFIG_PRIME_NUMBERS=m without this fix.

Reviewed-by: Kees Cook keescook@chromium.org

Thank you!

-- Kees Cook