Re: [PATCH v5 02/10] kunit: string-stream: Improve testing of string_stream

On 24/08/2023 23:42, Rae Moar wrote:

On Thu, Aug 24, 2023 at 10:31 AM Richard Fitzgerald rf@opensource.cirrus.com wrote:

...

Replace the minimal tests with more-thorough testing.

<SNIP>

...

•   KUNIT_EXPECT_EQ(test, stream->gfp, GFP_KERNEL);
  

As mentioned in the last version, if this causes a warning we will look into it on the KUnit side.

It does. I left it because you said you'd do a fix. But maybe it's better to change it to

KUNIT_EXPECT_TRUE(test, stream_gfp == GFP_KERNEL);

to avoid the warning for now.