On Fri, Sep 12, 2025 at 10:06 AM Stanislav Fomichev sdf@fomichev.me wrote:
RX devmem sometimes fails on NIPA:
https://netdev-3.bots.linux.dev/vmksft-fbnic-qemu-dbg/results/294402/7-devme...
Both RSS and flow steering are properly installed, but the wait_port_listen fails. Try to remove sleep(1) to see if the cause of the failure is spending too much time during RX setup.
OK, I can see that happening indeed.
I don't see a good reason to have sleep in the first place. If there needs to be a delay between installing the rules and receiving the traffic, let's add it to the callers (devmem.py) instead.
Yeah, I was worried there would be something asynchronous about installing flow steering rules (such as by the time when ethtool returns, the rule is not yet fully active), that may cause some flaky-iness, but that's unlikely the case.
Signed-off-by: Stanislav Fomichev sdf@fomichev.me
Reviewed-by: Mina Almasry almasrymina@google.com