On Tue, Jul 17, 2018 at 10:56:08AM -0700, Dave Hansen wrote:
On 07/17/2018 09:13 AM, Ram Pai wrote:
I have incorporated almost all of your comments. But there are some comments that take some effort to implement. Shall we get the patches merged in the current form? This code has been sitting out for a while.
In the current form its tested and works on powerpc and on x86, and incorporates about 95% of your suggestions. The rest I will take care as we go.
What constitutes the remaining 5%?
Mostly your comments on code-organization in the signal handler. There are still some #if defined(__i386__) ..... Can be cleaned up and abstracted further.
Also your questions on some of the code changes, the rationale for which is not obvious. Will help to spinkle in some descriptive comments there.
Have fixed up a lot of codying style issues. But there could till be a few that may spew warning by checkpatch.pl.
There are no functional issues AFAICT.
RP
-- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html