On Sat, Aug 12, 2023 at 04:32:41AM +0800, Zhangjin Wu wrote:
+CROSS_COMPILE_i386 ?= x86_64-linux- +CROSS_COMPILE_x86_64 ?= x86_64-linux- +CROSS_COMPILE_x86 ?= x86_64-linux- +CROSS_COMPILE_arm64 ?= aarch64-linux- +CROSS_COMPILE_arm ?= arm-linux-gnueabi- +CROSS_COMPILE_mips ?= mips64-linux-
Given that we don't support mips64, I'd suggest to ust mips-linux- instead here for now. That doesn't seem right to ask users to download a toolchain for a different architecture than the one supported just because we can adapt to it.
Agree very much, and the one below from patch 7/7 [1]:
+CROSS_COMPILE_arm64 ?= aarch64-linux- aarch64-linux-gnu- +CROSS_COMPILE_arm ?= arm-linux-gnueabi- arm-none-eabi- +CROSS_COMPILE_mips ?= mips64-linux- mips64el-linux-gnuabi64-
It should be:
+CROSS_COMPILE_mips ?= mips-linux- mips-linux-gnu-gcc
And if necessary, the mips64-linux- line in the commit message of [1] should be corrected too.
Thanks very much!
Best regards, Zhangjin [1]: https://lore.kernel.org/lkml/b06de47989e3138de3d178da0d705ad6560924ec.169178...
Willy