Re: [PATCH v8 30/30] KVM: selftests: TDX: Test LOG_DIRTY_PAGES flag to a non-GUEST_MEMFD memslot

Sagi Shahar wrote:

From: Yan Zhao yan.y.zhao@intel.com

Add a selftest to verify that adding flag KVM_MEM_LOG_DIRTY_PAGES to a !KVM_MEM_GUEST_MEMFD memslot does not produce host errors in TDX.

I'll pick on this patch for a general comment in for the series.

Most of the commit messages are light on the 'why' a patch exists. It may seem obvious that adding a test is to test some functionality. But that is not always the full story.

For example, here it would be nice for folks in the future to see what bug fix this was testing. Then if it starts failing we all know where to start looking for the regression.

Ira

[snip]