On 5/28/24 3:24 PM, Edward Liaw wrote:
On Wed, May 8, 2024 at 2:05 PM John Hubbard jhubbard@nvidia.com wrote:
On 5/2/24 9:18 PM, John Hubbard wrote:
It's slightly better to set _GNU_SOURCE in the source code, but if one must do it via the compiler invocation, then the best way to do so is this:
Hi Shuah, Edward and all,
This patch now seems to be obsolete, due to Edward Liaw's comprehensive fix, "[PATCH v2 0/5] Define _GNU_SOURCE for sources using" [1].
[1] https://lore.kernel.org/20240507214254.2787305-1-edliaw@google.com
Since we're dropping that patch, would we be able to merge this one? This should resolve the futex_requeue_pi compiler warnings with Clang.
Reviewed-by: Edward Liaw edliaw@google.com
Thanks for the review! I can post a v2 of this tiny series that has only patches 1 and 3, rebased on -rc1, so that it's clear what to merge.
thanks,