Re: [PATCH v1 11/20] arm64: enable ARCH_HAS_PKEYS on arm64

30 Sep 2023


      Hi Joey,
kernel test robot noticed the following build errors:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on linus/master v6.6-rc3 next-20230929]
[cannot apply to akpm-mm/mm-everything kvmarm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:    https://github.com/intel-lab-lkp/linux/commits/Joey-Gouly/arm64-sysreg-add-s...
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
patch link:    https://lore.kernel.org/r/20230927140123.5283-12-joey.gouly%40arm.com
patch subject: [PATCH v1 11/20] arm64: enable ARCH_HAS_PKEYS on arm64
config: arm64-randconfig-001-20230930 (https://download.01.org/0day-ci/archive/20230930/202309302050.SO3QXUkm-lkp@i...)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230930/202309302050.SO3QXUkm-lkp@i...)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot lkp@intel.com
| Closes: https://lore.kernel.org/oe-kbuild-all/202309302050.SO3QXUkm-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from arch/arm64/include/asm/hwcap.h:50,
                    from arch/arm64/include/asm/cpufeature.h:12,
                    from arch/arm64/include/asm/ptrace.h:11,
                    from arch/arm64/include/asm/irqflags.h:10,
                    from include/linux/irqflags.h:17,
                    from include/linux/spinlock.h:59,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from include/linux/mm.h:7,
                    from include/linux/pagewalk.h:5,
                    from fs/proc/task_mmu.c:2:
   fs/proc/task_mmu.c: In function 'show_smap_vma_flags':
   include/linux/mm.h:346:25: error: 'VM_HIGH_ARCH_2' undeclared (first use in this function)
     346 | # define VM_PKEY_BIT0   VM_HIGH_ARCH_2  /* A protection key is a 3-bit value on arm64 */
         |                         ^~~~~~~~~~~~~~
   include/linux/log2.h:158:30: note: in definition of macro 'ilog2'
     158 |         __builtin_constant_p(n) ?       \
         |                              ^
   fs/proc/task_mmu.c:689:24: note: in expansion of macro 'VM_PKEY_BIT0'
     689 |                 [ilog2(VM_PKEY_BIT0)]   = "",
         |                        ^~~~~~~~~~~~
   include/linux/mm.h:346:25: note: each undeclared identifier is reported only once for each function it appears in
     346 | # define VM_PKEY_BIT0   VM_HIGH_ARCH_2  /* A protection key is a 3-bit value on arm64 */
         |                         ^~~~~~~~~~~~~~
   include/linux/log2.h:158:30: note: in definition of macro 'ilog2'
     158 |         __builtin_constant_p(n) ?       \
         |                              ^
   fs/proc/task_mmu.c:689:24: note: in expansion of macro 'VM_PKEY_BIT0'
     689 |                 [ilog2(VM_PKEY_BIT0)]   = "",
         |                        ^~~~~~~~~~~~
...
...
include/linux/log2.h:157:1: error: array index in initializer not of integer type
157 | ( \
         | ^
   fs/proc/task_mmu.c:689:18: note: in expansion of macro 'ilog2'
     689 |                 [ilog2(VM_PKEY_BIT0)]   = "",
         |                  ^~~~~
   include/linux/log2.h:157:1: note: (near initialization for 'mnemonics')
     157 | ( \
         | ^
   fs/proc/task_mmu.c:689:18: note: in expansion of macro 'ilog2'
     689 |                 [ilog2(VM_PKEY_BIT0)]   = "",
         |                  ^~~~~
   include/linux/mm.h:347:25: error: 'VM_HIGH_ARCH_3' undeclared (first use in this function)
     347 | # define VM_PKEY_BIT1   VM_HIGH_ARCH_3
         |                         ^~~~~~~~~~~~~~
   include/linux/log2.h:158:30: note: in definition of macro 'ilog2'
     158 |         __builtin_constant_p(n) ?       \
         |                              ^
   fs/proc/task_mmu.c:690:24: note: in expansion of macro 'VM_PKEY_BIT1'
     690 |                 [ilog2(VM_PKEY_BIT1)]   = "",
         |                        ^~~~~~~~~~~~
...
...
include/linux/log2.h:157:1: error: array index in initializer not of integer type
157 | ( \
         | ^
   fs/proc/task_mmu.c:690:18: note: in expansion of macro 'ilog2'
     690 |                 [ilog2(VM_PKEY_BIT1)]   = "",
         |                  ^~~~~
   include/linux/log2.h:157:1: note: (near initialization for 'mnemonics')
     157 | ( \
         | ^
   fs/proc/task_mmu.c:690:18: note: in expansion of macro 'ilog2'
     690 |                 [ilog2(VM_PKEY_BIT1)]   = "",
         |                  ^~~~~
   include/linux/mm.h:348:25: error: 'VM_HIGH_ARCH_4' undeclared (first use in this function)
     348 | # define VM_PKEY_BIT2   VM_HIGH_ARCH_4
         |                         ^~~~~~~~~~~~~~
   include/linux/log2.h:158:30: note: in definition of macro 'ilog2'
     158 |         __builtin_constant_p(n) ?       \
         |                              ^
   fs/proc/task_mmu.c:691:24: note: in expansion of macro 'VM_PKEY_BIT2'
     691 |                 [ilog2(VM_PKEY_BIT2)]   = "",
         |                        ^~~~~~~~~~~~
...
...
include/linux/log2.h:157:1: error: array index in initializer not of integer type
157 | ( \
         | ^
   fs/proc/task_mmu.c:691:18: note: in expansion of macro 'ilog2'
     691 |                 [ilog2(VM_PKEY_BIT2)]   = "",
         |                  ^~~~~
   include/linux/log2.h:157:1: note: (near initialization for 'mnemonics')
     157 | ( \
         | ^
   fs/proc/task_mmu.c:691:18: note: in expansion of macro 'ilog2'
     691 |                 [ilog2(VM_PKEY_BIT2)]   = "",
         |                  ^~~~~
vim +157 include/linux/log2.h
b311e921b385b5a Robert f0d1b0b30d250a0 David Howells dbef91ec5482239 Martin Wilck a1c4d24e02d093e Randy Dunlap f0d1b0b30d250a0 David Howells dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck f0d1b0b30d250a0 David Howells dbef91ec5482239 Martin Wilck f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells 474c90156c8dcc2 Linus Torvalds f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells 474c90156c8dcc2 Linus Torvalds dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck dbef91ec5482239 Martin Wilck 2f78788b55baa34 Jakub Jelinek 2f78788b55baa34 Jakub Jelinek f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells f0d1b0b30d250a0 David Howells

P. J. Day 2007-10-16   69 2006-12-08   70  /** 2018-04-18   71   * const_ilog2 - log base 2 of 32-bit or a 64-bit constant unsigned value 2017-09-30   72   * @n: parameter 2006-12-08   73   * 2018-04-18   74   * Use this where sparse expects a true constant expression, e.g. for array 2018-04-18   75   * indices. 2006-12-08   76   */ 2018-04-18   77  #define const_ilog2(n)				\ 2006-12-08   78  (						\ 2006-12-08   79  	__builtin_constant_p(n) ? (		\ 2017-03-02   80  		(n) < 2 ? 0 :			\ 2006-12-08   81  		(n) & (1ULL << 63) ? 63 :	\ 2006-12-08   82  		(n) & (1ULL << 62) ? 62 :	\ 2006-12-08   83  		(n) & (1ULL << 61) ? 61 :	\ 2006-12-08   84  		(n) & (1ULL << 60) ? 60 :	\ 2006-12-08   85  		(n) & (1ULL << 59) ? 59 :	\ 2006-12-08   86  		(n) & (1ULL << 58) ? 58 :	\ 2006-12-08   87  		(n) & (1ULL << 57) ? 57 :	\ 2006-12-08   88  		(n) & (1ULL << 56) ? 56 :	\ 2006-12-08   89  		(n) & (1ULL << 55) ? 55 :	\ 2006-12-08   90  		(n) & (1ULL << 54) ? 54 :	\ 2006-12-08   91  		(n) & (1ULL << 53) ? 53 :	\ 2006-12-08   92  		(n) & (1ULL << 52) ? 52 :	\ 2006-12-08   93  		(n) & (1ULL << 51) ? 51 :	\ 2006-12-08   94  		(n) & (1ULL << 50) ? 50 :	\ 2006-12-08   95  		(n) & (1ULL << 49) ? 49 :	\ 2006-12-08   96  		(n) & (1ULL << 48) ? 48 :	\ 2006-12-08   97  		(n) & (1ULL << 47) ? 47 :	\ 2006-12-08   98  		(n) & (1ULL << 46) ? 46 :	\ 2006-12-08   99  		(n) & (1ULL << 45) ? 45 :	\ 2006-12-08  100  		(n) & (1ULL << 44) ? 44 :	\ 2006-12-08  101  		(n) & (1ULL << 43) ? 43 :	\ 2006-12-08  102  		(n) & (1ULL << 42) ? 42 :	\ 2006-12-08  103  		(n) & (1ULL << 41) ? 41 :	\ 2006-12-08  104  		(n) & (1ULL << 40) ? 40 :	\ 2006-12-08  105  		(n) & (1ULL << 39) ? 39 :	\ 2006-12-08  106  		(n) & (1ULL << 38) ? 38 :	\ 2006-12-08  107  		(n) & (1ULL << 37) ? 37 :	\ 2006-12-08  108  		(n) & (1ULL << 36) ? 36 :	\ 2006-12-08  109  		(n) & (1ULL << 35) ? 35 :	\ 2006-12-08  110  		(n) & (1ULL << 34) ? 34 :	\ 2006-12-08  111  		(n) & (1ULL << 33) ? 33 :	\ 2006-12-08  112  		(n) & (1ULL << 32) ? 32 :	\ 2006-12-08  113  		(n) & (1ULL << 31) ? 31 :	\ 2006-12-08  114  		(n) & (1ULL << 30) ? 30 :	\ 2006-12-08  115  		(n) & (1ULL << 29) ? 29 :	\ 2006-12-08  116  		(n) & (1ULL << 28) ? 28 :	\ 2006-12-08  117  		(n) & (1ULL << 27) ? 27 :	\ 2006-12-08  118  		(n) & (1ULL << 26) ? 26 :	\ 2006-12-08  119  		(n) & (1ULL << 25) ? 25 :	\ 2006-12-08  120  		(n) & (1ULL << 24) ? 24 :	\ 2006-12-08  121  		(n) & (1ULL << 23) ? 23 :	\ 2006-12-08  122  		(n) & (1ULL << 22) ? 22 :	\ 2006-12-08  123  		(n) & (1ULL << 21) ? 21 :	\ 2006-12-08  124  		(n) & (1ULL << 20) ? 20 :	\ 2006-12-08  125  		(n) & (1ULL << 19) ? 19 :	\ 2006-12-08  126  		(n) & (1ULL << 18) ? 18 :	\ 2006-12-08  127  		(n) & (1ULL << 17) ? 17 :	\ 2006-12-08  128  		(n) & (1ULL << 16) ? 16 :	\ 2006-12-08  129  		(n) & (1ULL << 15) ? 15 :	\ 2006-12-08  130  		(n) & (1ULL << 14) ? 14 :	\ 2006-12-08  131  		(n) & (1ULL << 13) ? 13 :	\ 2006-12-08  132  		(n) & (1ULL << 12) ? 12 :	\ 2006-12-08  133  		(n) & (1ULL << 11) ? 11 :	\ 2006-12-08  134  		(n) & (1ULL << 10) ? 10 :	\ 2006-12-08  135  		(n) & (1ULL <<  9) ?  9 :	\ 2006-12-08  136  		(n) & (1ULL <<  8) ?  8 :	\ 2006-12-08  137  		(n) & (1ULL <<  7) ?  7 :	\ 2006-12-08  138  		(n) & (1ULL <<  6) ?  6 :	\ 2006-12-08  139  		(n) & (1ULL <<  5) ?  5 :	\ 2006-12-08  140  		(n) & (1ULL <<  4) ?  4 :	\ 2006-12-08  141  		(n) & (1ULL <<  3) ?  3 :	\ 2006-12-08  142  		(n) & (1ULL <<  2) ?  2 :	\ 2017-03-02  143  		1) :				\ 2018-04-18  144  	-1) 2018-04-18  145 2018-04-18  146  /** 2018-04-18  147   * ilog2 - log base 2 of 32-bit or a 64-bit unsigned value 2018-04-18  148   * @n: parameter 2018-04-18  149   * 2018-04-18  150   * constant-capable log of base 2 calculation 2018-04-18  151   * - this can be used to initialise global variables from constant data, hence 2018-04-18  152   * the massive ternary operator construction 2018-04-18  153   * 2018-04-18  154   * selects the appropriately-sized optimised version depending on sizeof(n) 2018-04-18  155   */ 2018-04-18  156  #define ilog2(n) \ 2018-04-18 @157  ( \ 2018-04-18  158  	__builtin_constant_p(n) ?	\ 2020-12-15  159  	((n) < 2 ? 0 :			\ 2020-12-15  160  	 63 - __builtin_clzll(n)) :	\ 2006-12-08  161  	(sizeof(n) <= 4) ?		\ 2006-12-08  162  	__ilog2_u32(n) :		\ 2006-12-08  163  	__ilog2_u64(n)			\ 2006-12-08  164   ) 2006-12-08  165
-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

2024

2023

2022

2021

2020

2019

2018

2017

Re: [PATCH v1 11/20] arm64: enable ARCH_HAS_PKEYS on arm64