On Thu, Nov 07, 2024 at 02:26:11PM -0700, Shuah Khan wrote:
On 11/7/24 11:00, Catalin Marinas wrote:
On Thu, Nov 07, 2024 at 09:50:20AM -0700, Shuah Khan wrote:
On 11/7/24 06:16, Kevin Brodsky wrote:
Commit 6e182dc9f268 ("selftests/mm: Use generic pkey register manipulation") makes use of PKEY_UNRESTRICTED in pkey_sighandler_tests. The macro has been proposed for addition to uapi headers [1], but the patch hasn't landed yet.
Define PKEY_UNRESTRICTED in pkey-helpers.h for the time being to fix the build.
What does mean to say "time being" - can this be removed in the future. If so please add a FIXME so this define can be removed later.
There's a dependency on this series:
https://lore.kernel.org/r/20241028090715.509527-2-yury.khrustalev@arm.com/
Which I did not notice. Typically the uapi patches are picked by Arnd but first that series needs to be reposted with the comments addressed.
I think for now we either merge this fix from Kevin (happy to add a FIXME comment when applying), change the kselftest to use 0 instead of PKEY_UNRESTRICTED or revert the top two patches here:
https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-n...
I'm fine with all options really, it's not essential that we get the kselftest patches above merged in 6.13.
I am good with taking this patch as is with a FIXME to cleanup later.
Thanks Shuah.