Re: [PATCH 1/7] rust: kunit: support KUnit-mapped `assert!` macros in `#[test]`s

On Mon, May 5, 2025 at 8:02 AM David Gow davidgow@google.com wrote:

Nice! While I do think there may still be some cases where we might want to use KUnit-specific macros in the future (particularly if we have more complex, multithreaded test contexts), this is definitely better for most cases.

I also managed to test it against the 1.88 nightly, and the message is looking good.

Reviewed-by: David Gow davidgow@google.com

Thanks for all the feedback and for testing it, David! Very much appreciated.

Given you were happy with this first version already and that others want to use it soon, I did a few final minor tweaks and I am applying it.

Cheers, Miguel