Hello:
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov ast@kernel.org:
On Fri, 2 Dec 2022 18:08:44 -0700 you wrote:
Both tolower and toupper are built in c functions, we should not redefine them as this can result in a build error.
Fixes the following errors: progs/bpf_iter_ksym.c:10:20: error: conflicting types for built-in function 'tolower'; expected 'int(int)' [-Werror=builtin-declaration-mismatch] 10 | static inline char tolower(char c) | ^~~~~~~ progs/bpf_iter_ksym.c:5:1: note: 'tolower' is declared in header '<ctype.h>' 4 | #include <bpf/bpf_helpers.h> +++ |+#include <ctype.h> 5 | progs/bpf_iter_ksym.c:17:20: error: conflicting types for built-in function 'toupper'; expected 'int(int)' [-Werror=builtin-declaration-mismatch] 17 | static inline char toupper(char c) | ^~~~~~~ progs/bpf_iter_ksym.c:17:20: note: 'toupper' is declared in header '<ctype.h>'
[...]
Here is the summary with links: - [bpf-next,v2] selftests/bpf: Fix conflicts with built-in functions in bpf_iter_ksym https://git.kernel.org/bpf/bpf-next/c/ab0350c743d5
You are awesome, thank you!