Re: [PATCH v13 05/21] KVM: pfncache: remove KVM_GUEST_USES_PFN usage

On Thu, Feb 15, 2024, Paul Durrant wrote:

From: Paul Durrant pdurrant@amazon.com

As noted in [1] the KVM_GUEST_USES_PFN usage flag is never set by any callers of kvm_gpc_init(), which also makes the 'vcpu' argument redundant.

The changelog should explicitly call out that not only is KVM_GUEST_USES_PFN unused, it's incomplete/broken (which is also partly why it's unused). Without that information, removing the support looks like a somewhat arbitrary decision, versus a deliberate change to make it easier to support the gpc code.