Re: [PATCH v12 07/22] selftests/vm: fixed bugs in pkey_disable_clear()

Dave Hansen dave.hansen@intel.com writes:

On 03/28/2018 01:47 PM, Thiago Jung Bauermann wrote:

...

...

...

if (flags)

• assert(rdpkey_reg() > orig_pkey_reg);
  

• assert(rdpkey_reg() < orig_pkey_reg);
  

}

void pkey_write_allow(int pkey)

This seems so horribly wrong that I wonder how it worked in the first place. Any idea?

The code simply wasn't used. pkey_disable_clear() is called by pkey_write_allow() and pkey_access_allow(), but before this patch series nothing called either of these functions.

Ahh, that explains it. Can that get stuck in the changelog, please?

Yes, will be in the next version.