Re: [PATCH v6 7/8] Documentation: Add documentation for the Brute LSM

On Wed, Mar 17, 2021 at 09:10:05PM -0700, Kees Cook wrote:

On Sun, Mar 07, 2021 at 12:30:30PM +0100, John Wood wrote:

...

+These statistics are hold by the brute_stats struct.

+struct brute_cred {

• kuid_t uid;
• kgid_t gid;
• kuid_t suid;
• kgid_t sgid;
• kuid_t euid;
• kgid_t egid;
• kuid_t fsuid;
• kgid_t fsgid;

+};

+struct brute_stats {

• spinlock_t lock;
• refcount_t refc;
• unsigned char faults;
• u64 jiffies;
• u64 period;
• struct brute_cred saved_cred;
• unsigned char network : 1;
• unsigned char bounds_crossed : 1;

+};

Instead of open-coding this, just use the kerndoc references you've already built in the .c files:

.. kernel-doc:: security/brute/brute.c

Ok, thanks.

John Wood