On Mon, Sep 15, 2025 at 06:41:23PM -0700, Jakub Kicinski wrote:
On Mon, 15 Sep 2025 08:37:41 +0000 Hangbin Liu wrote:
The active-backup bonding mode supports XFRM ESP offload. However, when a bond is added using command like `ip link add bond0 type bond mode 1 miimon 100`, the `ethtool -k` command shows that the XFRM ESP offload is disabled. This occurs because, in bond_newlink(), we change bond link first and register bond device later. So the XFRM feature update in bond_option_mode_set() is not called as the bond device is not yet registered, leading to the offload feature not being set successfully.
To resolve this issue, we can modify the code order in bond_newlink() to ensure that the bond device is registered first before changing the bond link parameters. This change will allow the XFRM ESP offload feature to be correctly enabled.
This reportedly doesn't apply.. I suppose we want it to go via net?
Ah, yes. I forgot to add the target repo. I need to write a git format-patch wrapper to remind me adding it...
Regards Hangbin