Re: [PATCH v2 1/6] iommu: Add new iommu op to create domains owned by userspace

On Sun, Oct 15, 2023 at 12:14:01AM -0700, Nicolin Chen wrote:

On Thu, Sep 28, 2023 at 12:15:23AM -0700, Yi Liu wrote:

...

diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h index b4ba0c0cbab6..4a7c5c8fdbb4 100644 --- a/include/uapi/linux/iommufd.h +++ b/include/uapi/linux/iommufd.h @@ -347,10 +347,20 @@ struct iommu_vfio_ioas { }; #define IOMMU_VFIO_IOAS _IO(IOMMUFD_TYPE, IOMMUFD_CMD_VFIO_IOAS)

+/**

• • enum iommufd_hwpt_alloc_flags - Flags for HWPT allocation
• • @IOMMU_HWPT_ALLOC_NEST_PARENT: If set, allocate a domain which can serve

• •                            as the parent domain in the nesting
    

• •                            configuration.
    

I just noticed a nit here: we should probably align with other parts of this file by using "HWPT" v.s. "domain"? I.e.

• • @IOMMU_HWPT_ALLOC_NEST_PARENT: If set, allocate a HWPT which can serve

• •                            as the parent HWPT in the nesting
    

• •                            configuration.
    

Yes

Jason