On Sun, 2020-05-10 at 18:44 +0000, Nikita Sobolev wrote:
Hi, Jarkko Sakkinen, all!
Thank you for your notes about commit and sorry for not copying the message to you!
It's not a biggie, no worries.
There is definitely unwanted line of code in the commit. After deleting that one, introduced changes work fine.
There is a hardcoded usage of /dev/tpm2 in the kernel selftest. And if there is no such device - test fails. I believe this is not a behavior, that we expect. Test should be skipped in such case, should it? That is what my commit makes.
So, after deleting unwanted line of code and making cosmetic changes (new description + deleting excess newline character), can commit be submitted again?
You also mentioned reviewed-by nor tested-by tags in your message. Who should make these tags?
P.S. Also there was a question: why do I declare exit code with a constant instead of just exit 4. I chose this style because it is used in other kernel selftests for such kind of checks. It is proper to follow common style rules. Should I argument this decision in commit message?
-Nikita
Yes, you are of course free to submit a new patch for review.
/Jarkko