Re: [PATCH 2/4] bpf: Add dmabuf iterator

On Mon, Apr 14, 2025 at 3:53 PM T.J. Mercier tjmercier@google.com wrote: [...]

+BTF_ID_LIST_GLOBAL_SINGLE(bpf_dmabuf_btf_id, struct, dma_buf) +DEFINE_BPF_ITER_FUNC(dmabuf, struct bpf_iter_meta *meta, struct dma_buf *dmabuf)

+static void *dmabuf_iter_seq_start(struct seq_file *seq, loff_t *pos) +{

•   struct dma_buf *dmabuf, *ret = NULL;
  

•   if (*pos) {
  

•           *pos = 0;
  

•           return NULL;
  

•   }
  

•   /* Look for the first buffer we can obtain a reference to.
  

•    * The list mutex does not protect a dmabuf's refcount, so it can be
  

•    * zeroed while we are iterating. Therefore we cannot call get_dma_buf()
  

•    * since the caller of this program may not already own a reference to
  

•    * the buffer.
  

•    */
  

•   mutex_lock(&dmabuf_debugfs_list_mutex);
  

•   list_for_each_entry(dmabuf, &dmabuf_debugfs_list, list_node) {
  

•           if (file_ref_get(&dmabuf->file->f_ref)) {
  

•                   ret = dmabuf;
  

•                   break;
  

•           }
  

•   }
  

•   mutex_unlock(&dmabuf_debugfs_list_mutex);
  

IIUC, the iterator simply traverses elements in a linked list. I feel it is an overkill to implement a new BPF iterator for it. Maybe we simply use debugging tools like crash or drgn for this? The access with these tools will not be protected by the mutex. But from my personal experience, this is not a big issue for user space debugging tools.

Thanks, Song

•   return ret;
  

+}