Re: [PATCH 1/8] iommu: Introduce a replace API for device pasid

On Sun, Nov 26, 2023 at 10:34:21PM -0800, Yi Liu wrote:

+int iommu_replace_device_pasid(struct iommu_domain *domain,

• 	       struct device *dev, ioasid_t pasid)
  

+{

• struct iommu_group *group = dev->iommu_group;
• struct iommu_domain *old_domain;
• int ret;
• if (!domain)

• return -EINVAL;
  

• if (!group)

• return -ENODEV;
  

• mutex_lock(&group->mutex);
• __iommu_remove_group_pasid(group, pasid);

It is not replace if you do remove first.

Replace must just call set_dev_pasid and nothing much else..

Jason