-----Original Message----- From: Ido Schimmel idosch@idosch.org Sent: Monday, 28 August 2023 17:24 To: Sriram Yagnaraman sriram.yagnaraman@est.tech; kuba@kernel.org; pabeni@redhat.com Cc: netdev@vger.kernel.org; linux-kselftest@vger.kernel.org; David S . Miller davem@davemloft.net; Eric Dumazet edumazet@google.com; Jakub Kicinski kuba@kernel.org; Paolo Abeni pabeni@redhat.com; David Ahern dsahern@kernel.org; Ido Schimmel idosch@nvidia.com; Shuah Khan shuah@kernel.org; Petr Machata petrm@nvidia.com Subject: Re: [PATCH net v3 3/3] selftests: fib_tests: Add multipath list receive tests
On Mon, Aug 28, 2023 at 01:32:21PM +0200, Sriram Yagnaraman wrote:
The test uses perf stat to count the number of fib:fib_table_lookup tracepoint hits for IPv4 and the number of fib6:fib6_table_lookup for IPv6. The measured count is checked to be within 5% of the total number of packets sent via veth1.
Signed-off-by: Sriram Yagnaraman sriram.yagnaraman@est.tech
I just tested this with a debug config and noticed that the single path test is not very stable. It's not really related to the bug fix, so I think you can simply remove it.
Sent v4 with just the multipath test and rebased to latest after the merge with net-next.
If it is OK with all of you here, should I try to improve this test to verify TCP resets don't happen when the nexthop is in a multipath group, perhaps using iperf3? I can send another patch if/when I get something working.