Re: [RFC PATCH net-next v8 04/14] netdev: support binding dma-buf to netdevice

On Wed, Apr 24, 2024 at 10:36 AM David Wei dw@davidwei.uk wrote:

On 2024-04-02 5:20 pm, Mina Almasry wrote:

...

• /* We hold the rtnl_lock while binding/unbinding dma-buf, so we can't
  

•  * race with another thread that is also modifying this value. However,
  

•  * the driver may read this config while it's creating its * rx-queues.
  

•  * WRITE_ONCE() here to match the READ_ONCE() in the driver.
  

•  */
  

• WRITE_ONCE(rxq->mp_params.mp_priv, binding);
  

Is the mp_ops update missing here?

I do it in this patch, because it's the one that introduces mp_ops: https://patchwork.kernel.org/project/netdevbpf/patch/20240403002053.2376017-...