On Thu, Jan 11, 2024 at 11:40 AM Nathan Chancellor nathan@kernel.org wrote:
Hi Yonghong,
On Wed, Jan 10, 2024 at 08:05:36PM -0800, Yonghong Song wrote:
On 1/9/24 2:16 PM, Nathan Chancellor wrote:
reviews.llvm.org was LLVM's Phabricator instances for code review. It has been abandoned in favor of GitHub pull requests. While the majority of links in the kernel sources still work because of the work Fangrui has done turning the dynamic Phabricator instance into a static archive, there are some issues with that work, so preemptively convert all the links in the kernel sources to point to the commit on GitHub.
Most of the commits have the corresponding differential review link in the commit message itself so there should not be any loss of fidelity in the relevant information.
Additionally, fix a typo in the xdpwall.c print ("LLMV" -> "LLVM") while in the area.
Link: https://discourse.llvm.org/t/update-on-github-pull-requests/71540/172 Signed-off-by: Nathan Chancellor nathan@kernel.org
Ack with one nit below.
Acked-by: Yonghong Song yonghong.song@linux.dev
<snip>
@@ -304,6 +304,6 @@ from running test_progs will look like: .. code-block:: console
- test_xdpwall:FAIL:Does LLVM have https://reviews.llvm.org/D109073? unexpected error: -4007
- test_xdpwall:FAIL:Does LLVM have https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d0... unexpected error: -4007
-__ https://reviews.llvm.org/D109073 +__ https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d0...
To be consistent with other links, could you add the missing last alnum '5' to the above link?
Thanks a lot for catching this and providing an ack. Andrew, could you squash this update into selftests-bpf-update-llvm-phabricator-links.patch?
Please send a new patch. We'd like to take all bpf patches through the bpf tree to avoid conflicts.