Re: [PATCH v7 03/25] kernel: Unify update_vsyscall implementation

On Fri, Jun 21, 2019 at 10:52:30AM +0100, Vincenzo Frascino wrote:

diff --git a/kernel/vdso/vsyscall.c b/kernel/vdso/vsyscall.c new file mode 100644 index 000000000000..d1e8074e3d10 --- /dev/null +++ b/kernel/vdso/vsyscall.c +static inline void update_vdso_data(struct vdso_data *vdata,

• 		    struct timekeeper *tk)
  

+{

• struct vdso_timestamp *vdso_ts;
• u64 nsec;
• vdata[CS_HRES_COARSE].cycle_last = tk->tkr_mono.cycle_last;
• vdata[CS_HRES_COARSE].mask = tk->tkr_mono.mask;
• vdata[CS_HRES_COARSE].mult = tk->tkr_mono.mult;
• vdata[CS_HRES_COARSE].shift = tk->tkr_mono.shift;
• vdata[CS_RAW].cycle_last = tk->tkr_raw.cycle_last;
• vdata[CS_RAW].mask = tk->tkr_raw.mask;
• vdata[CS_RAW].mult = tk->tkr_raw.mult;
• vdata[CS_RAW].shift = tk->tkr_raw.shift;
• /* CLOCK_REALTIME */
• vdso_ts = &vdata[CS_HRES_COARSE].basetime[CLOCK_REALTIME];

There's an extraneous space after the '='. Hopefully Thomas can fix this up if this patchset is otherwise ok.

• vdso_ts->sec = tk->xtime_sec;
• vdso_ts->nsec = tk->tkr_mono.xtime_nsec;

Huw.