20 Jul
2025
20 Jul
'25
6:21 p.m.
On Mon, Jul 14, 2025 at 03:39:47PM -0600, Shuah Khan wrote:
On 7/14/25 15:26, Harshal wrote:
Specify details in logs of failed cases
How about changing the above to:
Improve error messages adding details on failuires
Will change this in next patch
fd = open(sys_path, O_WRONLY); if (fd < 0)
die("open failed: %s\n",
die("open of sys_path failed: %s\n",Why not just use sys_path as a input parameter to die()?
Sure, that's great. Is there a way to test these changes ?
@@ -129,8 +129,8 @@ int main(int argc, char **argv) die("error: failed to build full fw_path\n"); setup_fw(fw_path);
Why did you remove this line?
Will remove this change.
setvbuf(stdout, NULL, _IONBF, 0);
Why is this line added
This too.
Thanks, Harshal