Re: [PATCH v5 1/8] drivers: kunit: Generic helpers for test device creation

On Wed, Mar 22, 2023 at 11:05:55AM +0200, Matti Vaittinen wrote:

--- /dev/null +++ b/include/kunit/platform_device.h @@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */

+#ifndef __KUNIT_PLATFORM_DEVICE__ +#define __KUNIT_PLATFORM_DEVICE__

+#include <kunit/test.h>

+struct device;

+struct device *test_kunit_helper_alloc_device(struct kunit *test); +void test_kunit_helper_free_device(struct kunit *test, struct device *dev);

Why are you calling this a "platform_device" when it isn't a platform device at all?

Why not just say "device.h" here?

thanks,

greg k-h