Re: [PATCH v2 6/8] mm/huge_memory: remove stale NUMA hinting comment from follow_trans_huge_pmd()

On 01.08.23 18:07, Peter Xu wrote:

On Tue, Aug 01, 2023 at 02:48:42PM +0200, David Hildenbrand wrote:

...

diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 2cd3e5502180..0b709d2c46c6 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1467,7 +1467,6 @@ struct page *follow_trans_huge_pmd(struct vm_area_struct *vma, if ((flags & FOLL_DUMP) && is_huge_zero_pmd(*pmd)) return ERR_PTR(-EFAULT);

• /* Full NUMA hinting faults to serialise migration in fault paths */ if (pmd_protnone(*pmd) && !gup_can_follow_protnone(vma, flags)) return NULL;

Perhaps squashing into patch 1? Thanks,

I decided against it so I don't have to make patch description of patch #1 even longer with something that's mostly unrelated to the core change.