Re: [PATCH 2/7] of: Create of_root if no dtb provided by firmware

On Tue, Mar 12, 2024 at 03:41:32PM +0100, Geert Uytterhoeven wrote:

On Wed, Feb 21, 2024 at 3:06 PM Rob Herring robh+dt@kernel.org wrote:

static int __init regulator_init_complete(void)
{
        /*
         * Since DT doesn't provide an idiomatic mechanism for
         * enabling full constraints and since it's much more natural
         * with DT to provide them just assume that a DT enabled
         * system has full constraints.
         */
        if (of_have_populated_dt())
                has_full_constraints = true;

        ...
}
late_initcall_sync(regulator_init_complete);

(The latter looks a bit futile, as have_full_constraints() already contains a check for of_have_populated_dt()?)

Yes, it's duplicated and we should remove it.