On Wed, 24 Jan 2024 at 02:22, Johannes Berg johannes@sipsolutions.net wrote:
On Tue, 2024-01-23 at 19:19 +0100, Johannes Berg wrote:
We're also adding unit tests to iwlwifi (slowly), any idea if we should enable that here also? It _is_ now possible to build PCI stuff on kunit, but it requires some additional config options (virt-pci etc.), not sure that's desirable here? It doesn't need it at runtime for the tests, of course.
Heh, in fact Miri just posted the first bits:
https://lore.kernel.org/r/20240123200528.a4a8af7c091f.I0fb09083317b331168b99...
Also, should enabling that in tools/testing/kunit/configs/all_tests.config go through our tree, or better through the kselftest tree?
I'd definitely like the iwlwifi tests to be enabled in all_tests.config.
The virt-pci options _should_ already be enabled for the UML configs under kunit.py by default now (they're in .../configs/arch_uml.config).
I don't mind which tree the changes to all_tests.config go through -- I suspect it's probably better for them to go in via your tree, particularly if they end up depending on any new config options.
-- David