On Thu, 11 Dec 2025 01:31:09 +0000 Pavel Begunkov wrote:
Also RX_PAGE_SIZE is a better name for the fields? RX_BUF_SIZE is easy to confuse with RX_BUF_LEN which we are no longer trying to modify.
It's not "page" because there are no struct page's, and those are just buffers. Maybe it's also some net/driver specific term? I don't get the difference here b/w "size" and "len" either, but in any case I don't really have any real opinion about the name, and it can always be changed later.
RX_BUF_LEN is the existing config options which we were trying to use initially. We're not following that approach any more. The thinking about page is that we're replacing the device pages (rather than host struct page), in bnxt we're replacing a define called BNXT_RX_PAGE_SIZE. I suspect we'd be doing a similar replacement in most drivers, replace some define / math they have based on PAGE_SIZE