8 Mar
2024
8 Mar
'24
1:30 a.m.
On Mon, 4 Mar 2024 18:01:36 -0800 Mina Almasry wrote:
- void *(*ndo_queue_mem_alloc)(struct net_device *dev, int idx);
- Allocate memory for an RX queue. The memory returned in the form of
- a void * can be passed to ndo_queue_mem_free() for freeing or to
- ndo_queue_start to create an RX queue with this memory.
- void (*ndo_queue_mem_free)(struct net_device *dev, void *);
- Free memory from an RX queue.
- int (*ndo_queue_start)(struct net_device *dev, int idx, void *);
- Start an RX queue at the specified index.
- int (*ndo_queue_stop)(struct net_device *dev, int idx, void **);
*/
- Stop the RX queue at the specified index.
struct net_device_ops { int (*ndo_init)(struct net_device *dev); @@ -1679,6 +1693,16 @@ struct net_device_ops { int (*ndo_hwtstamp_set)(struct net_device *dev, struct kernel_hwtstamp_config *kernel_config, struct netlink_ext_ack *extack);
- void * (*ndo_queue_mem_alloc)(struct net_device *dev,
int idx);- void (*ndo_queue_mem_free)(struct net_device *dev,
void *queue_mem);- int (*ndo_queue_start)(struct net_device *dev,
int idx,void *queue_mem);- int (*ndo_queue_stop)(struct net_device *dev,
int idx,void **out_queue_mem);
The queue configuration object was quite an integral part of the design, I'm slightly worried that it's not here :) Also we may want to rename the about-to-be-merged ops from netdev_stat_ops and netdev_queue_ops, and add these there?
https://lore.kernel.org/all/20240306195509.1502746-2-kuba@kernel.org/
Very excited to hear that you made progress on this and ported GVE over!