Re: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for domain_alloc_user op

On Thu, Sep 21, 2023 at 08:12:03PM +0800, Baolu Lu wrote:

On 2023/9/21 15:51, Yi Liu wrote:

...

diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h index 4a7c5c8fdbb4..3c8660fe9bb1 100644 --- a/include/uapi/linux/iommufd.h +++ b/include/uapi/linux/iommufd.h @@ -357,6 +357,14 @@ enum iommufd_hwpt_alloc_flags { IOMMU_HWPT_ALLOC_NEST_PARENT = 1 << 0, }; +/**

• • enum iommu_hwpt_type - IOMMU HWPT Type
• • @IOMMU_HWPT_TYPE_DEFAULT: default

How about s/default/vendor agnostic/ ?

Please don't use the word vendor :)

IOMMU_HWPT_TYPE_GENERIC perhaps if we don't like default

Jason