On Fri, Mar 21, 2025 at 8:51 AM Mark Brown broonie@kernel.org wrote:
On Fri, Mar 21, 2025 at 05:37:50AM -0600, Nico Pache wrote:
On Thu, Mar 20, 2025 at 4:49 PM Mark Brown broonie@kernel.org wrote:
Simply adding it to the all_tests.config will just result in it getting turned off by Kconfig during the build since it's not a visible option so that's not accomplishing anything. all_tests.config is not UML specific, it's for enabling all the KUnit tests that could run in UML no matter how you're running them.
So would the correct approach be allowing users to select FW_CS_DSP, then apply these changes?
That user select should only be visible if KUnit is enabled though, it really is library code so shouldn't actually be user selectable. I'm not sure if there's some other strategy other KUnit tests for libraries use.
I'm a little confused how the FW_CS_DSP config which was added in v5.16 is reliant (library code that is only used by KUNIT) on a config that was added in v6.14. Presumably the library is not just for the KUNIT test. What was the purpose of this config before the introduction of the KUNIT test. Im guessing it was not user selectable back then too.
It also looks like FW_CS_DSP_KUNIT_TEST_UTILS and FW_CS_DSP_KUNIT_TEST are redundant.
Possibly there's more tests to come that'll use them?