On Fri, Dec 30, 2022 at 08:10:20PM +0800, Changbin Du wrote:
On Wed, Dec 21, 2022 at 11:55:24AM +0800, Leo Yan wrote:
On Tue, Dec 20, 2022 at 04:13:13PM -0800, Andrii Nakryiko wrote:
[...]
> @@ -990,6 +990,7 @@ static struct btf *btf_parse_elf(const char *path, struct btf *base_btf, > err = 0; > > if (!btf_data) { > + pr_warn("failed to find '%s' ELF section in %s\n", BTF_ELF_SEC, path); > err = -ENOENT;
btf_parse_elf() returns -ENOENT when ELF file doesn't contain BTF section, therefore, bpftool dumps error string "No such file or directory". It's confused that actually vmlinux is existed.
I am wondering if we can use error -LIBBPF_ERRNO__FORMAT (or any better choice?) to replace -ENOENT at here, this can avoid bpftool to outputs "No such file or directory" in this case.
The only really meaningful error code would be -ESRCH, which strerror() will translate to "No such process", which is also completely confusing.
Or maybe -ENODATA (No data available) is a better choice?
Thanks, Leo
Yan, will you have a patch for this suggestion?
You are welcome to send a patch, otherwise, I can cook one.
Thanks, Leo