Re: [PATCH v13 1/3] x86/tdx: Add TDX Guest attestation interface driver

On Fri, 2022-09-09 at 12:27 -0700, Kuppuswamy Sathyanarayanan wrote:

diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c index 928dcf7a20d9..8b5c59110321 100644 --- a/arch/x86/coco/tdx/tdx.c +++ b/arch/x86/coco/tdx/tdx.c @@ -5,16 +5,21 @@  #define pr_fmt(fmt)     "tdx: " fmt    #include <linux/cpufeature.h> +#include <linux/miscdevice.h> +#include <linux/mm.h> +#include <linux/io.h>

Sorry perhaps I am missing something, but what is the reason to include <linux/mm.h>?

<linux/io.h> is for virt_to_phys()?

And should we explicitly include <linux/uaccess.h> for copy_{from|to}_user(), and include the header (<linux/string.h> ?) for memchr_inv()?