On Thu, 2025-05-08 at 13:42 -0700, Mina Almasry wrote:
Thank you very much.
Reviewed-by: Mina Almasry almasrymina@google.com
Thank you for the review.
Also, I think there was a discussion in v1 about increasing the amount of memory that ncdevmem uses by default (currently it's 64MB) as Stan suggested. I have it in my TODO list to implement that change but I don't think I'll get to it soon. If you (or anyone) gets to it before me, it's a welcome change. AFAIU it'll unblock you from running ncdevmem on your driver which expects much more dmabuf memory available.
But to be clear, that can be a follow up change. I think this is good as-is.
I do plan to follow-up on that topic, mlx5 will require some reengineering to not fail rx rings refill when the pool is too small, and most likely some touch-ups in ncdevmem/udmabuf to make this better.
Cosmin.