On 11/23/22 16:26, Maxime Ripard wrote:

It's fairly hard to figure out the instance of the CRTC affected by an atomic change using the default name.

Since we can provide our own to the CRTC initialization functions, let's do so to make the debugging sessions easier.

Signed-off-by: Maxime Ripard maxime@cerno.tech

drivers/gpu/drm/vc4/vc4_crtc.c | 10 +++++++++- drivers/gpu/drm/vc4/vc4_drv.h | 2 ++ drivers/gpu/drm/vc4/vc4_txp.c | 1 + 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 8bc30ad0904b..59e473059fa2 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -1118,6 +1118,7 @@ static const struct drm_crtc_helper_funcs vc4_crtc_helper_funcs = { static const struct vc4_pv_data bcm2835_pv0_data = { .base = {

• .name = "pixelvalve-0",
  

I wonder if would make sense to add the SoC name too, but either way:

Reviewed-by: Javier Martinez Canillas javierm@redhat.com