Hi Linus,
Please pull the following Kunit fixes update for Linux 5.10-rc3
This Kunit update for Linux 5.10-rc3 consists of several kunit_tool and documentation fixes.
diff is attached.
thanks, -- Shuah
---------------------------------------------------------------- The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec:
Linux 5.10-rc1 (2020-10-25 15:14:11 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest tags/linux-kselftest-kunit-fixes-5.10-rc3
for you to fetch changes up to 0d0d245104a42e593adcf11396017a6420c08ba8:
kunit: tools: fix kunit_tool tests for parsing test plans (2020-10-26 13:25:40 -0600)
---------------------------------------------------------------- linux-kselftest-kunit-fixes-5.10-rc3
This Kunit update for Linux 5.10-rc3 consists of several kunit_tool and documentation fixes.
---------------------------------------------------------------- Andy Shevchenko (1): kunit: Don't fail test suites if one of them is empty
Brendan Higgins (1): kunit: tools: fix kunit_tool tests for parsing test plans
David Gow (1): kunit: Fix kunit.py --raw_output option
Mauro Carvalho Chehab (1): kunit: test: fix remaining kernel-doc warnings
SeongJae Park (1): Documentation: kunit: Update Kconfig parts for KUNIT's module support
Documentation/dev-tools/kunit/start.rst | 2 +- Documentation/dev-tools/kunit/usage.rst | 5 ++++ include/kunit/test.h | 16 +++++------ tools/testing/kunit/kunit_parser.py | 3 +- tools/testing/kunit/kunit_tool_test.py | 32 ++++++++++++++++----- .../kunit/test_data/test_config_printk_time.log | Bin 1584 -> 1605 bytes .../test_data/test_interrupted_tap_output.log | Bin 1982 -> 2003 bytes .../test_data/test_kernel_panic_interrupt.log | Bin 1321 -> 1342 bytes .../kunit/test_data/test_multiple_prefixes.log | Bin 1832 -> 1861 bytes .../kunit/test_data/test_pound_no_prefix.log | Bin 1193 -> 1200 bytes tools/testing/kunit/test_data/test_pound_sign.log | Bin 1656 -> 1676 bytes 11 files changed, 40 insertions(+), 18 deletions(-)
----------------------------------------------------------------
On Thu, Nov 5, 2020 at 8:55 AM Shuah Khan skhan@linuxfoundation.org wrote:
.../kunit/test_data/test_config_printk_time.log | Bin 1584 -> 1605 bytes .../test_data/test_interrupted_tap_output.log | Bin 1982 -> 2003 bytes .../test_data/test_kernel_panic_interrupt.log | Bin 1321 -> 1342 bytes .../kunit/test_data/test_multiple_prefixes.log | Bin 1832 -> 1861
This diffstat is a bit annoying.
And the reason is that we have
[torvalds@ryzen linux]$ cat tools/testing/kunit/.gitattributes test_data/* binary
iow, you're telling git that everything in that test_data directory is binary blobs. Which isn't actually true.
This isn't new, but it was just more noticeable this time around.
That binary marker comes from commit afc63da64f1e ("kunit: kunit_parser: make parser more robust") and I'm not really seeing the reason for it.
Linus
On Thu, Nov 5, 2020 at 12:02 PM Linus Torvalds torvalds@linux-foundation.org wrote:
On Thu, Nov 5, 2020 at 8:55 AM Shuah Khan skhan@linuxfoundation.org wrote:
.../kunit/test_data/test_config_printk_time.log | Bin 1584 -> 1605 bytes .../test_data/test_interrupted_tap_output.log | Bin 1982 -> 2003 bytes .../test_data/test_kernel_panic_interrupt.log | Bin 1321 -> 1342 bytes .../kunit/test_data/test_multiple_prefixes.log | Bin 1832 -> 1861
This diffstat is a bit annoying.
Oh, and another note: because you don't have the "[GIT PULL}" marker on the subject line, the pr-tracker-bot doesn't react to the pull requests, and you didn't get notified that it's been pulled.
Just FYI - I personally don't care, as your pull requests do show up in _my_ queue, because you have "git" and "pull" in the body of the message. But the automation doesn't see them.
Linus
On 11/5/20 1:25 PM, Linus Torvalds wrote:
On Thu, Nov 5, 2020 at 12:02 PM Linus Torvalds torvalds@linux-foundation.org wrote:
On Thu, Nov 5, 2020 at 8:55 AM Shuah Khan skhan@linuxfoundation.org wrote:
.../kunit/test_data/test_config_printk_time.log | Bin 1584 -> 1605 bytes .../test_data/test_interrupted_tap_output.log | Bin 1982 -> 2003 bytes .../test_data/test_kernel_panic_interrupt.log | Bin 1321 -> 1342 bytes .../kunit/test_data/test_multiple_prefixes.log | Bin 1832 -> 1861
This diffstat is a bit annoying.
Oh, and another note: because you don't have the "[GIT PULL}" marker on the subject line, the pr-tracker-bot doesn't react to the pull requests, and you didn't get notified that it's been pulled.
Just FYI - I personally don't care, as your pull requests do show up in _my_ queue, because you have "git" and "pull" in the body of the message. But the automation doesn't see them.
Oops. I don't usually miss adding [GIT PULL] - will pay more attention.
I am sorry about that. My bad on my part. Can I chalk it up to this weird week?
thanks, -- Shuah
On Thu, Nov 5, 2020 at 2:01 PM Shuah Khan skhan@linuxfoundation.org wrote:
Oops. I don't usually miss adding [GIT PULL] - will pay more attention.
No problem. As mentioned, my own workflow doesn't actually care as long as the body of the mail has that "please pull" and "git" mentioned.
And I wouldn't have noticed the pr-tracker-bot reply missing either, if it wasn't for the fact that I replied to the pull request for other reasons..
So no worries, just a note on how that "[GIT PULL]" marker might be helpful for _you_ to see "oh, Linus pulled it, I can forget about it".
Linus
On 11/5/20 1:02 PM, Linus Torvalds wrote:
On Thu, Nov 5, 2020 at 8:55 AM Shuah Khan skhan@linuxfoundation.org wrote:
.../kunit/test_data/test_config_printk_time.log | Bin 1584 -> 1605 bytes .../test_data/test_interrupted_tap_output.log | Bin 1982 -> 2003 bytes .../test_data/test_kernel_panic_interrupt.log | Bin 1321 -> 1342 bytes .../kunit/test_data/test_multiple_prefixes.log | Bin 1832 -> 1861
This diffstat is a bit annoying.
And the reason is that we have
[torvalds@ryzen linux]$ cat tools/testing/kunit/.gitattributes test_data/* binaryiow, you're telling git that everything in that test_data directory is binary blobs. Which isn't actually true.
This isn't new, but it was just more noticeable this time around.
That binary marker comes from commit afc63da64f1e ("kunit: kunit_parser: make parser more robust") and I'm not really seeing the reason for it.
You are right. It appears there is no need to add these binary blobs. Brendan and I discussed this and he will send a fix to remove the blobs and redo the test output. In other words fix commit afc63da64f1e.
Sorry for not catching this earlier.
thanks, -- Shuah
linux-kselftest-mirror@lists.linaro.org
-
Linus Torvalds -
Shuah Khan