socket.c: In function ‘run_tests’: socket.c:59:25: warning: ignoring return value of ‘strerror_r’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 59 | strerror_r(-s->expect, err_string1, ERR_STRING_SZ); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ socket.c:60:25: warning: ignoring return value of ‘strerror_r’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 60 | strerror_r(errno, err_string2, ERR_STRING_SZ); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ socket.c:73:33: warning: ignoring return value of ‘strerror_r’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 73 | strerror_r(errno, err_string1, ERR_STRING_SZ); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Alex Tran alex.t.tran@gmail.com --- tools/testing/selftests/net/socket.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/net/socket.c b/tools/testing/selftests/net/socket.c index db1aeb8c5d1e..7c597c583df3 100644 --- a/tools/testing/selftests/net/socket.c +++ b/tools/testing/selftests/net/socket.c @@ -39,6 +39,8 @@ static int run_tests(void) { char err_string1[ERR_STRING_SZ]; char err_string2[ERR_STRING_SZ]; + char *err_message1; + char *err_message2; int i, err;
err = 0; @@ -56,13 +58,13 @@ static int run_tests(void) errno == -s->expect) continue;
- strerror_r(-s->expect, err_string1, ERR_STRING_SZ); - strerror_r(errno, err_string2, ERR_STRING_SZ); + err_message1 = strerror_r(-s->expect, err_string1, ERR_STRING_SZ); + err_message2 = strerror_r(errno, err_string2, ERR_STRING_SZ);
fprintf(stderr, "socket(%d, %d, %d) expected " "err (%s) got (%s)\n", s->domain, s->type, s->protocol, - err_string1, err_string2); + err_message1, err_message2);
err = -1; break; @@ -70,12 +72,12 @@ static int run_tests(void) close(fd);
if (s->expect < 0) { - strerror_r(errno, err_string1, ERR_STRING_SZ); + err_message1 = strerror_r(errno, err_string1, ERR_STRING_SZ);
fprintf(stderr, "socket(%d, %d, %d) expected " "success got err (%s)\n", s->domain, s->type, s->protocol, - err_string1); + err_message1);
err = -1; break;
On Thu, 14 Aug 2025 23:06:31 -0700 Alex Tran wrote:
- char *err_message1;
- char *err_message2;
nit, how about:
const char *msg1, *msg2;
? And then please wrap the lines at 80 chars.
int i, err; err = 0; @@ -56,13 +58,13 @@ static int run_tests(void) errno == -s->expect) continue;
strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
strerror_r(errno, err_string2, ERR_STRING_SZ);
err_message1 = strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
err_message2 = strerror_r(errno, err_string2, ERR_STRING_SZ);
Thanks for the review! I'll send the patch v2 with the adjustments shortly.
On Mon, Aug 18, 2025 at 5:35 PM Jakub Kicinski kuba@kernel.org wrote:
On Thu, 14 Aug 2025 23:06:31 -0700 Alex Tran wrote:
char *err_message1;
char *err_message2;
nit, how about:
const char *msg1, *msg2;
? And then please wrap the lines at 80 chars.
int i, err; err = 0;
@@ -56,13 +58,13 @@ static int run_tests(void) errno == -s->expect) continue;
strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
strerror_r(errno, err_string2, ERR_STRING_SZ);
err_message1 = strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
err_message2 = strerror_r(errno, err_string2, ERR_STRING_SZ);
linux-kselftest-mirror@lists.linaro.org