Add the tty_tiocsti_test binary to .gitignore to avoid accidentally staging the build artifact.
Signed-off-by: Gopi Krishna Menon krishnagopi487@gmail.com --- tools/testing/selftests/tty/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore index fe70462a4aad..2453685d2493 100644 --- a/tools/testing/selftests/tty/.gitignore +++ b/tools/testing/selftests/tty/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only +tty_tiocsti_test tty_tstamp_update
On 10/24/25 12:19, Gopi Krishna Menon wrote:
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally staging the build artifact.
Why do we want to ignore building this artifact? When submitting a patch, it is important to list "why" something is needed. Not just what is done.
Signed-off-by: Gopi Krishna Menon krishnagopi487@gmail.com
tools/testing/selftests/tty/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore index fe70462a4aad..2453685d2493 100644 --- a/tools/testing/selftests/tty/.gitignore +++ b/tools/testing/selftests/tty/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only +tty_tiocsti_test tty_tstamp_update
Thanks, David Hunter
Building the tty selftests generates the tty_tiocsti_test binary, which appears as untracked file in git. As mentioned in the kselftest documentation, all the generated objects must be placed inside .gitignore. This prevents the generated objects from accidentally getting staged and keeps the working tree clean.
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally staging the build artifact and maintain a clean working tree.
Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-deta...
Suggested-by: David Hunter david.hunter.linux@gmail.com Signed-off-by: Gopi Krishna Menon krishnagopi487@gmail.com --- Changelog: - Improve the commit wording and explain clearly why this change is needed.
tools/testing/selftests/tty/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore index fe70462a4aad..2453685d2493 100644 --- a/tools/testing/selftests/tty/.gitignore +++ b/tools/testing/selftests/tty/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only +tty_tiocsti_test tty_tstamp_update
On Sun, Oct 26, 2025 at 12:55:46PM +0530, Gopi Krishna Menon wrote:
Building the tty selftests generates the tty_tiocsti_test binary, which appears as untracked file in git. As mentioned in the kselftest documentation, all the generated objects must be placed inside .gitignore. This prevents the generated objects from accidentally getting staged and keeps the working tree clean.
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally staging the build artifact and maintain a clean working tree.
Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-deta...
Suggested-by: David Hunter david.hunter.linux@gmail.com Signed-off-by: Gopi Krishna Menon krishnagopi487@gmail.com
Changelog:
- Improve the commit wording and explain clearly why this change is needed.
tools/testing/selftests/tty/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore index fe70462a4aad..2453685d2493 100644 --- a/tools/testing/selftests/tty/.gitignore +++ b/tools/testing/selftests/tty/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only +tty_tiocsti_test tty_tstamp_update -- 2.43.0
Shouldn't this go through the tty tree that added this test?
thanks,
greg k-h
Building the tty selftests generates the tty_tiocsti_test binary, which appears as untracked file in git. As mentioned in the kselftest documentation, all the generated objects must be placed inside .gitignore. This prevents the generated objects from accidentally getting staged and keeps the working tree clean.
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally staging the build artifact and maintain a clean working tree.
Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-deta...
Suggested-by: David Hunter david.hunter.linux@gmail.com Signed-off-by: Gopi Krishna Menon krishnagopi487@gmail.com --- Changelog: - Improve the commit wording and explain clearly why this change is needed.
tools/testing/selftests/tty/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore index fe70462a4aad..2453685d2493 100644 --- a/tools/testing/selftests/tty/.gitignore +++ b/tools/testing/selftests/tty/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only +tty_tiocsti_test tty_tstamp_update
On Sun, Oct 26, 2025 at 02:52:32PM +0530, Gopi Krishna Menon wrote:
Building the tty selftests generates the tty_tiocsti_test binary, which appears as untracked file in git. As mentioned in the kselftest documentation, all the generated objects must be placed inside .gitignore. This prevents the generated objects from accidentally getting staged and keeps the working tree clean.
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally staging the build artifact and maintain a clean working tree.
Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-deta...
Suggested-by: David Hunter david.hunter.linux@gmail.com Signed-off-by: Gopi Krishna Menon krishnagopi487@gmail.com
Changelog:
- Improve the commit wording and explain clearly why this change is needed.
What commit id does this fix?
thanks,
greg k-h
Building the tty selftests generates the tty_tiocsti_test binary, which appears as untracked file in git. As mentioned in the kselftest documentation, all the generated objects must be placed inside .gitignore. This prevents the generated objects from accidentally getting staged and keeps the working tree clean.
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally staging the build artifact and maintain a clean working tree.
Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-deta...
Fixes: 7553f5173ec3 ("selftests/tty: add TIOCSTI test suite") Suggested-by: Greg KH gregkh@linuxfoundation.org Suggested-by: David Hunter david.hunter.linux@gmail.com Signed-off-by: Gopi Krishna Menon krishnagopi487@gmail.com --- Changelog: v3: - Add fixes tag as suggested by Greg KH. v2: - Improve the commit wording and explain clearly why this change is needed.
tools/testing/selftests/tty/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore index fe70462a4aad..2453685d2493 100644 --- a/tools/testing/selftests/tty/.gitignore +++ b/tools/testing/selftests/tty/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only +tty_tiocsti_test tty_tstamp_update
linux-kselftest-mirror@lists.linaro.org
-
David Hunter -
Gopi Krishna Menon -
Greg KH