From: Rong Tao rongtao@cestc.cn
Add test scripts and prompts.
Signed-off-by: Rong Tao rongtao@cestc.cn --- tools/testing/selftests/splice/splice_read.c | 1 + tools/testing/selftests/splice/splice_read.sh | 9 +++++++++ 2 files changed, 10 insertions(+) create mode 100755 tools/testing/selftests/splice/splice_read.sh
diff --git a/tools/testing/selftests/splice/splice_read.c b/tools/testing/selftests/splice/splice_read.c index 46dae6a25cfb..194b075f6bc0 100644 --- a/tools/testing/selftests/splice/splice_read.c +++ b/tools/testing/selftests/splice/splice_read.c @@ -49,6 +49,7 @@ int main(int argc, char *argv[]) size, SPLICE_F_MOVE); if (spliced < 0) { perror("splice"); + fprintf(stderr, "May try: %s /etc/os-release | cat\n", argv[0]); return EXIT_FAILURE; }
diff --git a/tools/testing/selftests/splice/splice_read.sh b/tools/testing/selftests/splice/splice_read.sh new file mode 100755 index 000000000000..10fd5d738a2d --- /dev/null +++ b/tools/testing/selftests/splice/splice_read.sh @@ -0,0 +1,9 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +set -e +nl=$(./splice_read /etc/os-release | wc -l) + +test "$nl" != 0 && exit 0 + +echo "splice_read broken" +exit 1
On 8/27/24 21:40, Rong Tao wrote:
From: Rong Tao rongtao@cestc.cn
Add test scripts and prompts.
Can you give more details on what these scripts and prompts do?
Signed-off-by: Rong Tao rongtao@cestc.cn
tools/testing/selftests/splice/splice_read.c | 1 + tools/testing/selftests/splice/splice_read.sh | 9 +++++++++ 2 files changed, 10 insertions(+) create mode 100755 tools/testing/selftests/splice/splice_read.sh
diff --git a/tools/testing/selftests/splice/splice_read.c b/tools/testing/selftests/splice/splice_read.c index 46dae6a25cfb..194b075f6bc0 100644 --- a/tools/testing/selftests/splice/splice_read.c +++ b/tools/testing/selftests/splice/splice_read.c @@ -49,6 +49,7 @@ int main(int argc, char *argv[]) size, SPLICE_F_MOVE); if (spliced < 0) { perror("splice");
fprintf(stderr, "May try: %s /etc/os-release | cat\n", argv[0]);
Is this supposed to be usage or help message?
return EXIT_FAILURE;} diff --git a/tools/testing/selftests/splice/splice_read.sh b/tools/testing/selftests/splice/splice_read.sh new file mode 100755 index 000000000000..10fd5d738a2d --- /dev/null +++ b/tools/testing/selftests/splice/splice_read.sh @@ -0,0 +1,9 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +set -e +nl=$(./splice_read /etc/os-release | wc -l)
+test "$nl" != 0 && exit 0
+echo "splice_read broken" +exit 1
thanks, -- Shuah
On 8/30/24 8:37 PM, Shuah Khan wrote:
On 8/27/24 21:40, Rong Tao wrote:
From: Rong Tao rongtao@cestc.cn
Add test scripts and prompts.
Can you give more details on what these scripts and prompts do?
I just push v2(https://lore.kernel.org/lkml/tencent_0AEA8FB622DE1A740841643D5F36ABF8BD0A@qq...)
At the first time, I just want to do the same thing that default_file_splice_read.sh did,
and splice_read.sh looks like useless, i just remove splice_read.sh in v2.
Signed-off-by: Rong Tao rongtao@cestc.cn
tools/testing/selftests/splice/splice_read.c | 1 + tools/testing/selftests/splice/splice_read.sh | 9 +++++++++ 2 files changed, 10 insertions(+) create mode 100755 tools/testing/selftests/splice/splice_read.sh
diff --git a/tools/testing/selftests/splice/splice_read.c b/tools/testing/selftests/splice/splice_read.c index 46dae6a25cfb..194b075f6bc0 100644 --- a/tools/testing/selftests/splice/splice_read.c +++ b/tools/testing/selftests/splice/splice_read.c @@ -49,6 +49,7 @@ int main(int argc, char *argv[]) size, SPLICE_F_MOVE); if (spliced < 0) { perror("splice"); + fprintf(stderr, "May try: %s /etc/os-release | cat\n", argv[0]);
Is this supposed to be usage or help message?
Yes, I just add usage() function to splice_read.c in v2(https://lore.kernel.org/lkml/tencent_0AEA8FB622DE1A740841643D5F36ABF8BD0A@qq...)
Please review, thanks.
return EXIT_FAILURE; } diff --git a/tools/testing/selftests/splice/splice_read.sh b/tools/testing/selftests/splice/splice_read.sh new file mode 100755 index 000000000000..10fd5d738a2d --- /dev/null +++ b/tools/testing/selftests/splice/splice_read.sh @@ -0,0 +1,9 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +set -e +nl=$(./splice_read /etc/os-release | wc -l)
+test "$nl" != 0 && exit 0
+echo "splice_read broken" +exit 1
thanks, -- Shuah
Thank you.
Rong Tao
linux-kselftest-mirror@lists.linaro.org
-
Rong Tao -
Shuah Khan