On 2021/10/11 22:30, Daniel Borkmann wrote:

On 10/11/21 1:19 PM, Wan Jiabing wrote:

...

Fix following checkincludes.pl warning: ./tools/testing/selftests/bpf/cgroup_helpers.c 12    #include <unistd.h>      14    #include <unistd.h>

What does the 12 vs 14 mean here? Please provide a proper commit description, e.g. if you used checkincludes.pl, maybe include the full command invocation and the relevant output, so that this is more obvious and in a better shape. Thanks!

Sorry for my fuzzy description. 12 and 14 mean the line of includes file. The script checkincludes.pl can only show which file is included duplicated, like

./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more than once.

So I upgrade the script so it can tell me the position of the duplicated includes.

I'll fix the description in v2.

...

Signed-off-by: Wan Jiabing wanjiabing@vivo.com

tools/testing/selftests/bpf/cgroup_helpers.c | 1 -   1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c index 8fcd44841bb2..9d59c3990ca8 100644 --- a/tools/testing/selftests/bpf/cgroup_helpers.c +++ b/tools/testing/selftests/bpf/cgroup_helpers.c @@ -11,7 +11,6 @@   #include <fcntl.h>   #include <unistd.h>   #include <ftw.h> -#include <unistd.h>     #include "cgroup_helpers.h"