On Sat, Jan 02, 2021 at 03:52:32PM +0200, Andy Shevchenko wrote:

On Saturday, January 2, 2021, Kent Gibson warthog618@gmail.com wrote:

...

The GPIO mockup selftests are overly complicated with separate implementations of the tests for sysfs and cdev uAPI, and with the cdev implementation being dependent on tools/gpio and libmount.

Rework the test implementation to provide a common test suite with a simplified pluggable uAPI interface. The cdev implementation utilises the GPIO uAPI directly to remove the dependence on tools/gpio. The simplified uAPI interface removes the need for any file system mount checks in C, and so removes the dependence on libmount.

The rework also fixes the sysfs test implementation which has been broken since the device created in the multiple gpiochip case was split into separate devices.

I briefly looked at code in shell below... there are places to improve (useless use of: cat, test, negation, etc).

My shell is clearly pretty poor, so I would really appreciate a pointer to an example of each, and I'll then hunt down the rest.

Thanks, Kent.