Due to bpf_map_lookup_elem being declared static we need to also declare subprog_noise as static.
Fixes the following error: progs/tailcall_bpf2bpf4.c:26:9: error: 'bpf_map_lookup_elem' is static but used in inline function 'subprog_noise' which is not static [-Werror] 26 | bpf_map_lookup_elem(&nop_table, &key); | ^~~~~~~~~~~~~~~~~~~
Signed-off-by: James Hilliard james.hilliard1@gmail.com --- tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c index b67e8022d500..a017d6b2f1dd 100644 --- a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c +++ b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c @@ -19,7 +19,7 @@ struct { int count = 0; int noise = 0;
-__always_inline int subprog_noise(void) +static __always_inline int subprog_noise(void) { __u32 key = 0;
On Thu, Aug 25, 2022 at 8:52 PM James Hilliard james.hilliard1@gmail.com wrote:
Due to bpf_map_lookup_elem being declared static we need to also declare subprog_noise as static.
Fixes the following error: progs/tailcall_bpf2bpf4.c:26:9: error: 'bpf_map_lookup_elem' is static but used in inline function 'subprog_noise' which is not static [-Werror] 26 | bpf_map_lookup_elem(&nop_table, &key); | ^~~~~~~~~~~~~~~~~~~
Signed-off-by: James Hilliard james.hilliard1@gmail.com
Acked-by: Song Liu song@kernel.org
tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c index b67e8022d500..a017d6b2f1dd 100644 --- a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c +++ b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c @@ -19,7 +19,7 @@ struct { int count = 0; int noise = 0;
-__always_inline int subprog_noise(void) +static __always_inline int subprog_noise(void) { __u32 key = 0;
-- 2.34.1
Hello:
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko andrii@kernel.org:
On Thu, 25 Aug 2022 21:51:39 -0600 you wrote:
Due to bpf_map_lookup_elem being declared static we need to also declare subprog_noise as static.
Fixes the following error: progs/tailcall_bpf2bpf4.c:26:9: error: 'bpf_map_lookup_elem' is static but used in inline function 'subprog_noise' which is not static [-Werror] 26 | bpf_map_lookup_elem(&nop_table, &key); | ^~~~~~~~~~~~~~~~~~~
[...]
Here is the summary with links: - selftests/bpf: declare subprog_noise as static in tailcall_bpf2bpf4 https://git.kernel.org/bpf/bpf-next/c/b05d64efbb21
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org