Trivial patches to update the gitignore files unders selftests, and a little addition to EXTRA_CLEAN under net/rds to account for the automatically generated include.sh.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- Javier Carrasco (4): selftests: add unshare_test and msg_oob to gitignore selftests: rds: add include.sh to EXTRA_CLEAN selftests: rds: add gitignore file for include.sh selftests: exec: update gitignore for load_address
tools/testing/selftests/core/.gitignore | 1 + tools/testing/selftests/exec/.gitignore | 2 +- tools/testing/selftests/net/.gitignore | 1 + tools/testing/selftests/net/rds/.gitignore | 1 + tools/testing/selftests/net/rds/Makefile | 2 +- 5 files changed, 5 insertions(+), 2 deletions(-) --- base-commit: 4d0326b60bb753627437fff0f76bf1525bcda422 change-id: 20240924-selftests-gitignore-e41133e6c5bd
Best regards,
These executables are missing from their corresponding gitignore files. Add them to the lists.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- tools/testing/selftests/core/.gitignore | 1 + tools/testing/selftests/net/.gitignore | 1 + 2 files changed, 2 insertions(+)
diff --git a/tools/testing/selftests/core/.gitignore b/tools/testing/selftests/core/.gitignore index 6e6712ce5817..7999361992aa 100644 --- a/tools/testing/selftests/core/.gitignore +++ b/tools/testing/selftests/core/.gitignore @@ -1 +1,2 @@ close_range_test +unshare_test diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore index 1c04c780db66..9dcdff533414 100644 --- a/tools/testing/selftests/net/.gitignore +++ b/tools/testing/selftests/net/.gitignore @@ -17,6 +17,7 @@ ipv6_flowlabel ipv6_flowlabel_mgr log.txt msg_zerocopy +msg_oob ncdevmem nettest psock_fanout
The include.sh file is generated when building the net/rds selftests, but there is no rule to delete it with the clean target. Add the file to EXTRA_CLEAN in order to remove it when required.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- tools/testing/selftests/net/rds/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile index da9714bc7aad..0b697669ea51 100644 --- a/tools/testing/selftests/net/rds/Makefile +++ b/tools/testing/selftests/net/rds/Makefile @@ -7,6 +7,6 @@ TEST_PROGS := run.sh \ include.sh \ test.py
-EXTRA_CLEAN := /tmp/rds_logs +EXTRA_CLEAN := /tmp/rds_logs include.sh
include ../../lib.mk
On Tue, 2024-09-24 at 14:49 +0200, Javier Carrasco wrote:
The include.sh file is generated when building the net/rds selftests, but there is no rule to delete it with the clean target. Add the file to EXTRA_CLEAN in order to remove it when required.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com
Ok, looks good. Thanks for catching this Reviewed-by: Allison Henderson allison.henderson@oracle.com
tools/testing/selftests/net/rds/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile index da9714bc7aad..0b697669ea51 100644 --- a/tools/testing/selftests/net/rds/Makefile +++ b/tools/testing/selftests/net/rds/Makefile @@ -7,6 +7,6 @@ TEST_PROGS := run.sh \ include.sh \ test.py -EXTRA_CLEAN := /tmp/rds_logs +EXTRA_CLEAN := /tmp/rds_logs include.sh include ../../lib.mk
The generated include.sh should be ignored by git. Create a new gitignore and add the file to the list.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- tools/testing/selftests/net/rds/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/rds/.gitignore b/tools/testing/selftests/net/rds/.gitignore new file mode 100644 index 000000000000..1c6f04e2aa11 --- /dev/null +++ b/tools/testing/selftests/net/rds/.gitignore @@ -0,0 +1 @@ +include.sh
On Tue, 2024-09-24 at 14:49 +0200, Javier Carrasco wrote:
The generated include.sh should be ignored by git. Create a new gitignore and add the file to the list.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com
Thanks! Reviewed-by: Allison Henderson allison.henderson@oracle.com
tools/testing/selftests/net/rds/.gitignore | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/rds/.gitignore b/tools/testing/selftests/net/rds/.gitignore new file mode 100644 index 000000000000..1c6f04e2aa11 --- /dev/null +++ b/tools/testing/selftests/net/rds/.gitignore @@ -0,0 +1 @@ +include.sh
The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated.
Update the load_address entry in the gitignore file to account for the new names.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com --- tools/testing/selftests/exec/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/exec/.gitignore b/tools/testing/selftests/exec/.gitignore index 90c238ba6a4b..4d9fb7b20ea7 100644 --- a/tools/testing/selftests/exec/.gitignore +++ b/tools/testing/selftests/exec/.gitignore @@ -9,7 +9,7 @@ execveat.ephemeral execveat.denatured non-regular null-argv -/load_address_* +/load_address.* /recursion-depth xxxxxxxx* pipe
Hi Javier,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 4d0326b60bb753627437fff0f76bf1525bcda422]
url: https://github.com/intel-lab-lkp/linux/commits/Javier-Carrasco/selftests-add... base: 4d0326b60bb753627437fff0f76bf1525bcda422 patch link: https://lore.kernel.org/r/20240924-selftests-gitignore-v1-4-9755ac883388%40g... patch subject: [PATCH 4/4] selftests: exec: update gitignore for load_address config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20240925/202409251828.dMx8LnrF-lkp@i...) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240925/202409251828.dMx8LnrF-lkp@i...)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot lkp@intel.com | Closes: https://lore.kernel.org/oe-kbuild-all/202409251828.dMx8LnrF-lkp@intel.com/
All warnings (new ones prefixed by >>):
tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files
tools/testing/selftests/exec/load_address.c: warning: ignored by one of the .gitignore files
On 9/24/24 06:49, Javier Carrasco wrote:
The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated.
Update the load_address entry in the gitignore file to account for the new names.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com
tools/testing/selftests/exec/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/exec/.gitignore b/tools/testing/selftests/exec/.gitignore index 90c238ba6a4b..4d9fb7b20ea7 100644 --- a/tools/testing/selftests/exec/.gitignore +++ b/tools/testing/selftests/exec/.gitignore @@ -9,7 +9,7 @@ execveat.ephemeral execveat.denatured non-regular null-argv -/load_address_* +/load_address.*
Hmm. This will include the load_address.c which shouldn't be included in the .gitignore?
/recursion-depth xxxxxxxx* pipe
thanks, -- Shuah
On 25/09/2024 17:46, Shuah Khan wrote:
On 9/24/24 06:49, Javier Carrasco wrote:
The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated.
Update the load_address entry in the gitignore file to account for the new names.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com
tools/testing/selftests/exec/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/exec/.gitignore b/tools/testing/ selftests/exec/.gitignore index 90c238ba6a4b..4d9fb7b20ea7 100644 --- a/tools/testing/selftests/exec/.gitignore +++ b/tools/testing/selftests/exec/.gitignore @@ -9,7 +9,7 @@ execveat.ephemeral execveat.denatured non-regular null-argv -/load_address_* +/load_address.*
Hmm. This will include the load_address.c which shouldn't be included in the .gitignore?
/recursion-depth xxxxxxxx* pipe
thanks, -- Shuah
Hi, the kernel test robot already notified me about that issue, and I sent a v2 to fix it shortly after. Please take a look at the newer version where I added the exception for load_address.c.
Thanks and best regards, Javier Carrasco
On 9/25/24 10:25, Javier Carrasco wrote:
On 25/09/2024 17:46, Shuah Khan wrote:
On 9/24/24 06:49, Javier Carrasco wrote:
The name of the "load_address" objects has been modified, but the corresponding entry in the gitignore file must be updated.
Update the load_address entry in the gitignore file to account for the new names.
Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com
tools/testing/selftests/exec/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/exec/.gitignore b/tools/testing/ selftests/exec/.gitignore index 90c238ba6a4b..4d9fb7b20ea7 100644 --- a/tools/testing/selftests/exec/.gitignore +++ b/tools/testing/selftests/exec/.gitignore @@ -9,7 +9,7 @@ execveat.ephemeral execveat.denatured non-regular null-argv -/load_address_* +/load_address.*
Hmm. This will include the load_address.c which shouldn't be included in the .gitignore?
/recursion-depth xxxxxxxx* pipe
thanks, -- Shuah
Hi, the kernel test robot already notified me about that issue, and I sent a v2 to fix it shortly after. Please take a look at the newer version where I added the exception for load_address.c.
Thanks. I saw your v2 after sending this email. I have a comment on v2 to split core and net patch
thanks, -- Shuah
linux-kselftest-mirror@lists.linaro.org
-
Allison Henderson -
Javier Carrasco -
kernel test robot -
Shuah Khan