``` readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" readonly BASE=`basename $STATS` ``` It could be a mistake to write to $BASE rather than $STATS, where $STATS is used to save the NSTAT_HISTORY and it will be cleaned up before exit.
Although since we've been creating the wrong file this whole time and everything worked, it's fine to remove these 2 lines completely
Cc: "David S. Miller" davem@davemloft.net Cc: Eric Dumazet edumazet@google.com Cc: Jakub Kicinski kuba@kernel.org Cc: Paolo Abeni pabeni@redhat.com Signed-off-by: Li Zhijian lizhijian@fujitsu.com --- Cc: netdev@vger.kernel.org --- V3: Remove these 2 lines rather than fixing the filename
--- Hello, Cover letter is here.
This patch set aims to make 'git status' clear after 'make' and 'make run_tests' for kselftests. --- V2: nothing change
Signed-off-by: Li Zhijian lizhijian@fujitsu.com --- tools/testing/selftests/net/veth.sh | 2 -- 1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh index 4f1edbafb946..6bb7dfaa30b6 100755 --- a/tools/testing/selftests/net/veth.sh +++ b/tools/testing/selftests/net/veth.sh @@ -46,8 +46,6 @@ create_ns() { ip -n $BASE$ns addr add dev veth$ns $BM_NET_V4$ns/24 ip -n $BASE$ns addr add dev veth$ns $BM_NET_V6$ns/64 nodad done - echo "#kernel" > $BASE - chmod go-rw $BASE }
__chk_flag() {
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski kuba@kernel.org:
On Wed, 30 Oct 2024 08:59:43 +0800 you wrote:
readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" readonly BASE=`basename $STATS`
It could be a mistake to write to $BASE rather than $STATS, where $STATS is used to save the NSTAT_HISTORY and it will be cleaned up before exit.
[...]
Here is the summary with links: - [v3] selftests/net: Fix ./ns-XXXXXX not cleanup https://git.kernel.org/netdev/net-next/c/d3774a4b21e9
You are awesome, thank you!
linux-kselftest-mirror@lists.linaro.org