On 29/10/2024 07:46, Jason Xing wrote:

From: Jason Xing kernelxing@tencent.com

As we can see from the title, when I compiled the selftests/bpf, I saw the error: implicit declaration of function ‘gettid’ ; did you mean ‘getgid’? [-Werror=implicit-function-declaration] skel->bss->tid = gettid(); ^~~~~~ getgid

Directly call the syscall solves this issue.

Signed-off-by: Jason Xing kernelxing@tencent.com

Reviewed-by: Alan Maguire alan.maguire@oracle.com Tested-by: Alan Maguire alan.maguire@oracle.com

---

v2 Link: https://lore.kernel.org/all/20241028034143.14675-1-kerneljasonxing@gmail.com...

1. directly call the syscall (Andrii)

---

tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c index f0a3a9c18e9e..9006549a1294 100644 --- a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c +++ b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c @@ -226,7 +226,7 @@ static void test_task_common_nocheck(struct bpf_iter_attach_opts *opts, ASSERT_OK(pthread_create(&thread_id, NULL, &do_nothing_wait, NULL), "pthread_create");

• skel->bss->tid = gettid();

• skel->bss->tid = syscall(SYS_gettid);

do_dummy_read_opts(skel->progs.dump_task, opts); @@ -255,10 +255,10 @@ static void *run_test_task_tid(void *arg) union bpf_iter_link_info linfo; int num_unknown_tid, num_known_tid;

• ASSERT_NEQ(getpid(), gettid(), "check_new_thread_id");

• ASSERT_NEQ(getpid(), syscall(SYS_gettid), "check_new_thread_id");

memset(&linfo, 0, sizeof(linfo));

• linfo.task.tid = gettid();

• linfo.task.tid = syscall(SYS_gettid); opts.link_info = &linfo; opts.link_info_len = sizeof(linfo); test_task_common(&opts, 0, 1);